-
Notifications
You must be signed in to change notification settings - Fork 31
Jg/v3.1 vcf changes #365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jg/v3.1 vcf changes #365
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small changes and some questions (I haven't fully reviewed https://github.com/broadinstitute/gnomad_qc/pull/191/files yet)
Co-authored-by: Katherine Chao <[email protected]>
…om/broadinstitute/gnomad_methods into jg/v3.1_vcf_changes � Conflicts: � gnomad/resources/grch38/gnomad.py � gnomad/utils/vcf.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few more tiny things + this needs a CHANGELOG update since it replaces ht_to_vcf_mt
Co-authored-by: Katherine Chao <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
These are additions/changes needed for the cleaned up version of the gnomAD v3.1 VCF export PR (broadinstitute/gnomad_qc#191).