Skip to content

Conversation

@jkgoodrich
Copy link
Contributor

These are additions/changes needed for the cleaned up version of the gnomAD v3.1 VCF export PR (broadinstitute/gnomad_qc#191).

Copy link
Contributor

@ch-kr ch-kr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small changes and some questions (I haven't fully reviewed https://github.com/broadinstitute/gnomad_qc/pull/191/files yet)

@jkgoodrich jkgoodrich requested a review from ch-kr May 14, 2021 17:36
Copy link
Contributor

@ch-kr ch-kr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few more tiny things + this needs a CHANGELOG update since it replaces ht_to_vcf_mt

@jkgoodrich jkgoodrich requested a review from ch-kr May 18, 2021 19:33
Copy link
Contributor

@ch-kr ch-kr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jkgoodrich jkgoodrich merged commit e6f8e5f into master May 18, 2021
@jkgoodrich jkgoodrich deleted the jg/v3.1_vcf_changes branch May 18, 2021 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants